chore: build/config boilerplate alignment audit - #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audited this repo's build/config boilerplate against the rest of the ecosystem (using marten-identity as the reference).
Findings
.editorconfig: kept the 26-line variant, not extended to the 45-line one used by Blazor-bearing repos. This repo is a plain C# class library with zero.razor/.cshtml/.css/.scss/.jsfiles, so the extra sections would be inert. Documented the reasoning inCLAUDE.mdunder a new "Conventions Audit" section so this isn't re-litigated as apparent drift later.tests/*.csprojboilerplate: no drift found against marten-identity's pattern. The differences that exist (marten-identity's test projects referenceFrameworkReference Microsoft.AspNetCore.AppandNSubstitute) are usage-driven — this repo's tests don't need ASP.NET Core or mocking — not drift.GlobalUsings.cs: already consistent (global using Xunit;, matching marten-identity).No code changes; this is a documentation-only PR recording a completed audit.
Test plan
dotnet build— 0 warnings, 0 errorsdotnet test— 4/4 passingdotnet list package --vulnerable --include-transitive— cleanCloses #14