Skip to content

fix: dark-mode CSS leaks — listbox hover, base buttons, light badges, grid stripes #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andregoepel merged 2 commits into from
Jul 17, 2026
Merged

fix: dark-mode CSS leaks — listbox hover, base buttons, light badges, grid stripes #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e227182
fix: dark-mode hover on Radzen listbox items is unreadable
andregoepel Jul 17, 2026
fd937c8
fix: remap the base and grid-stripe tokens leaking light theme into d…
andregoepel Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/AndreGoepel.Design.Blazor/wwwroot/css/design.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,24 @@
/* borders */
--rz-border-color: var(--ag-border);
--rz-base-300: var(--ag-border);
/* Neutral base ramp — Radzen's light defaults otherwise leak into the dark shell:
--rz-base / --rz-on-base back ButtonStyle.Base (which DialogService.Confirm uses for
its Cancel button) and --rz-base-200 backs BadgeStyle.Light (measured 1.2:1 contrast
unmapped). Keep 200 a step below the already-mapped 300 (#4). */
--rz-base-200: var(--ag-hover);
--rz-base: var(--ag-hover);
--rz-on-base: var(--ag-text);
--rz-input-border-color: var(--ag-border2);
--rz-input-disabled-background: var(--ag-hover);
--rz-border-radius: 6px;
--rz-card-border-radius: 10px;

/* data grid surfaces (Radzen defaults are white — break dark mode row hover) */
/* data grid surfaces (Radzen defaults are white — break dark mode row hover and the
striped-row background, which otherwise alternates to Radzen's light default) (#4) */
--rz-grid-background-color: var(--ag-surface);
--rz-grid-hover-background-color: var(--ag-hover);
--rz-grid-stripe-background-color: var(--ag-hover);
--rz-grid-stripe-odd-background-color: var(--ag-surface);

/* status colours */
--rz-success: var(--ag-accent);
Expand Down Expand Up @@ -261,7 +271,13 @@ h4:focus-visible, h5:focus-visible, h6:focus-visible {
color: var(--ag-text2);
}

.rz-listbox .rz-listbox-item:hover {
/* Radzen's material-base hover rule is
`.rz-listbox:not(.rz-state-disabled) .rz-listbox-item:hover:hover` — the doubled
`:hover` and the `:not()` are a deliberate specificity bump. A plain
`.rz-listbox-item:hover` loses to it, leaving the light base-theme hover colour in
dark mode (unreadable dark text on a light row). Match the selector exactly so this
layer — loaded after material-base — wins on source order. */
.rz-listbox:not(.rz-state-disabled) .rz-listbox-item:hover:hover {
background: var(--ag-hover);
color: var(--ag-text);
}
Expand Down