fix: add MemberNotNullWhen to Result.IsSuccess/IsFailure - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1.
Adds `[MemberNotNullWhen(false, nameof(Error))]` to `IsSuccess` and `[MemberNotNullWhen(true, nameof(Error))]` to `IsFailure`, so consumers under `TreatWarningsAsErrors` can read `result.Error` inside either branch (`if (result.IsFailure) { ...Error... }` or `if (result.IsSuccess) {...} else { ...Error... }`) without a null-forgiving operator or CS8602.
Added two tests that only compile clean if the annotations are correct — no `!` and no explicit null-check on `Error`, relying purely on the attributes to satisfy nullable analysis. This repo's own `Directory.Build.props` already has `TreatWarningsAsErrors`, so a wrong annotation here would fail the build, not just a runtime assertion.
Purely additive (attribute-only, no shape change) — safe for the app-foundation PR #146 that already depends on 1.0.0.
Verification: `dotnet csharpier format .` clean, `dotnet build -c Release` 0 warnings/errors, `dotnet test` 6/6 passed, `dotnet list package --vulnerable --include-transitive` clean.
🤖 Generated with Claude Code