fix(security): pin transitive AngleSharp to 1.5.2 (mXSS advisory)#98
Merged
Conversation
bUnit 2.7.2 -> AngleSharp.Diffing 1.1.1 resolves AngleSharp to 1.4.0, which carries a moderate mXSS advisory (GHSA-pgww-w46g-26qg / CVE-2026-54570) and trips the CI vulnerability gate. Enable CentralPackageTransitivePinningEnabled and pin AngleSharp to the patched 1.5.2 via Directory.Packages.props (no direct PackageReference needed). Temporary — tracked for removal in #97 once bUnit resolves to >= 1.5.0 on its own. Transitive pinning enforces every central version as a pin, which surfaced two previously-unused stale entries sitting below their transitive requirement: Marten.AspNetCore (9.0.2 -> 9.14.1) and Quartz.Extensions.Hosting (3.18.1 -> 3.18.2). Both are aligned to the versions already resolved transitively — no behavioural change. `dotnet list package --vulnerable --include-transitive` is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI vulnerability gate (
dotnet list package --vulnerable) fails:bunit 2.7.2→AngleSharp.Diffing 1.1.1resolves AngleSharp 1.4.0, which carries a moderate mXSS advisory (GHSA-pgww-w46g-26qg / CVE-2026-54570).Fix
Mirrors the temporary pin done in marten-identity (#106/#107): enable
CentralPackageTransitivePinningEnabledand pin AngleSharp 1.5.2 inDirectory.Packages.props, overriding the transitive resolution without a directPackageReference.Transitive pinning enforces every central version as a pin, which surfaced two previously-unused stale central entries sitting below their transitive requirement (via
Marten.Identity1.3.1). Both are aligned to the versions already resolved transitively — no behavioural change:Marten.AspNetCore9.0.2 → 9.14.1Quartz.Extensions.Hosting3.18.1 → 3.18.2Verification
dotnet restore --force-evaluatesucceeds; AngleSharp now resolves to 1.5.2 (CentralTransitive).dotnet list package --vulnerable --include-transitivereports no vulnerable packages across all projects (previously flagged AngleSharp inAndreGoepel.AppFoundation.Tests).--locked-moderestore stays reproducible.Follow-up
Temporary. Tracked for removal in #97 once bUnit ships a transitive chain that resolves AngleSharp to ≥ 1.5.0 on its own.
Closes nothing — the tracking issue (#97) stays open by design until the pin can be dropped.