feat: align error pages with the design system#83
Merged
Conversation
- Error (/Error): replace the raw Bootstrap-styled markup with the design page skeleton (heading + muted subtitle, a card for the development-mode note) and use AppFoundationPageTitle. - ErrorPage (404/403): use AppFoundationPageTitle for a brand-suffixed title. NotFound (delegates to ErrorPage) and EmptyLayout (a pass-through layout) need no changes.
…re-execute The 404 surface had been unwired since the flip to a packable RCL: the sample host's Routes.razor lost the old <NotFound> section and NotFound.razor had no route, so unknown URLs returned a bare 404. - NotFound.razor gets @page "/not-found" and reads an optional ?code= query so a re-executed 403 renders its own copy - the sample Router points NotFoundPage at it (interactive navigations) - UseAppFoundation adds UseStatusCodePagesWithReExecute("/not-found", "?code={0}") so hard requests that match no endpoint render the designed page for every consumer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final small slice of the design migration — the error/utility pages.
/Error): the raw Bootstrap-styled markup (text-dangerheadings, bare<p>s) becomes the design page skeleton — heading + muted subtitle and a card for the development-mode note — and usesAppFoundationPageTitle.AppFoundationPageTitlefor a brand-suffixed title (already used the reskinned Radzen card).ErrorPage) and EmptyLayout (pass-through layout) need no changes.Verification
dotnet build: 0 errors · unit tests: 56/56 (incl. the ErrorPage/NotFound tests) · csharpier: passesWith this, all of app-foundation's own pages use the design system. The identity flows (login, 2FA, manage, admin dialogs) come designed from the
AndreGoepel.Marten.Identity.Blazorpackage.