feat: adopt ReconnectModal from design-blazor, delete local copy - #169
Merged
Conversation
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes the local
ReconnectModal(razor + css + js + its localization test) in favor of the version shipped byAndreGoepel.Design.Blazor(already at 1.6.0, well past the 1.5.0 release that added it). CSS was byte-identical between the two copies; the local copy's JS/markup had drifted — its resume button was missing thecomponents-resume-failed-visibleclass, so on a failed resume it fell back tolocation.reload()instead of showing the proper resume-failed UI state the package version has.Also removed the now-unused
Reconnect.*resx keys (the package component sources its own strings fromDesignStringsindependently) and a stale doc-table mention inTECHNICAL.md.Note for a follow-up, not this ticket: the local
ReconnectModalwas never actually referenced anywhere in this repo (MainLayout.razor,EmptyLayout.razor, the sample'sApp.razor— none render it), confirmed via repo-wide grep and checked against downstream consumers. This is dead code that predates this consolidation, not something introduced by this change. Whether host apps should wire up<ReconnectModal />fromAndreGoepel.Design.Blazor.Componentsis a separate decision.Verification
dotnet csharpier format .cleandotnet build— 0 warnings, 0 errorsdotnet test(non-E2E) — 29 + 5 + 88 + 3 = 125 passingdotnet list package --vulnerable --include-transitive— cleanCloses #148