feat: adopt protected-secret support from marten-configuration - #167
Merged
Conversation
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MartenEmailSettingsStore.SaveAsyncnow callsAndreGoepel.Marten.Configuration'sDataProtectorExtensions.ProtectOrKeepExistinginstead of hand-rolling the "protect new value or keep existing ciphertext" branching. Identical failure semantics preserved: fails only when there's neither a new password nor an existing document. BumpedAndreGoepel.Marten.Configuration1.0.1 → 1.1.0.Verification
dotnet csharpier format .cleandotnet build— 0 warnings, 0 errorsdotnet test— 91 + 29 + 5 = 125 passing, including existingMartenEmailSettingsStoreTestscovering all three branches unchangeddotnet list package --vulnerable --include-transitive— cleanCloses #155