feat: introduce shared Result<T> in AndreGoepel.AppFoundation.Core - #140
Merged
Conversation
This was referenced Jul 26, 2026
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Result/Result<T>toAndreGoepel.AppFoundation.Core(zero-dependency package,1.8.0→1.9.0) as the canonical implementation of the shared convention "Result<T>for error handling — no exceptions for flow control".Resolves the decision on #138 (option 1): introduce the shared type here rather than softening the convention.
andregoepel/finance-appalready has an equivalent hand-rolledResult<T>(same shape:IsSuccess/Error/IsFailure,Ok()/Fail(string)/Ok<T>(value)/Fail<T>(string)) — this type is intentionally identical in shape so finance-app (and any other repo) can adopt it later as a drop-in replacement rather than a rewrite. No repo is migrated in this PR; adoption is incremental per the issue.Also updated
.claude-shared/dotnet-conventions.mdto point at this as the canonical type.Verification:
dotnet csharpier format .clean,dotnet build0 errors,dotnet test --filter "FullyQualifiedName!~E2ETests"117/117 passed (4 new + 113 existing),dotnet list package --vulnerable --include-transitiveclean.Closes #138
🤖 Generated with Claude Code