Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix colors dependency to 1.4.0 exactly #15

Open
donmahallem opened this issue Jan 9, 2022 · 2 comments
Open

Fix colors dependency to 1.4.0 exactly #15

donmahallem opened this issue Jan 9, 2022 · 2 comments

Comments

@donmahallem
Copy link

Due to this 'controvery' currently appnest is broken if one doesn't lock colors himself. Would be great if you could atleast temporarly remove the minor version scope from the dependency or replace with some other.
donmahallem added a commit to donmahallem/readme that referenced this issue Jan 9, 2022
@donmahallem
fix(deps): lock colors dependency to 1.4.0
93d6ac1 
Due to this [commit](Marak/colors.js@074a0f8) by the maintainer colors is currently "broken". This commit is in reference to andreasbm#15
@donmahallem donmahallem mentioned this issue Jan 9, 2022
Open
@keerl
Copy link

keerl commented Jan 9, 2022

+1 would like to see this merged and published asap. This breaks dozens of open-source projects I help maintain.

@brianespinosa
Copy link

@andreasbm this is a pretty important security fix. It looks like @donmahallem already has a fork with the small change. Any chance we could get a PR in for this security fix ASAP? I am also happy to make an official PR if that will help move things along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brianespinosa @donmahallem @keerl