Add support for child view controller's layout preferences. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 10, 2019
| @@ -173,7 +173,16 @@ open class ScrollingNavigationController: UINavigationController, UIGestureRecog | |||
| var scrollSpeedFactor: CGFloat = 1 | |||
| var collapseDirectionFactor: CGFloat = 1 // Used to determine the sign of content offset depending of collapse direction | |||
| var previousState: NavigationBarState = .expanded // Used to mark the state before the app goes in background | |||
|
|
|||
|
|
|||
| private var isTopViewControllerExtendsUnderNavigationBar: Bool { | |||
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'isTopViewControllerExtendsUnderNavigationBar' (identifier_name)
|
Hey @evil159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #364