Skip to content

Commit

Permalink
perf ordered_events: Add ordered_events__flush_time interface
Browse files Browse the repository at this point in the history
Add OE_FLUSH__TIME flush type, to be able to flush only certain amount
of the queue based on the provided timestamp. It will be used in the
following patches.

Signed-off-by: Jiri Olsa <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Dmitry Levin <[email protected]>
Cc: Eugene Syromiatnikov <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Luis Cláudio Gonçalves <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Steven Rostedt (VMware) <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
[ Fix the build on older systems such as centos 5 and 6 where 'time' shadows a global declaration ]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
  • Loading branch information
olsajiri authored and acmel committed Dec 17, 2018
1 parent 6d99a79 commit 68ca5d0
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 4 deletions.
23 changes: 19 additions & 4 deletions tools/perf/util/ordered-events.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,7 @@ int ordered_events__queue(struct ordered_events *oe, union perf_event *event,
return 0;
}

static int __ordered_events__flush(struct ordered_events *oe,
bool show_progress)
static int do_flush(struct ordered_events *oe, bool show_progress)
{
struct list_head *head = &oe->events;
struct ordered_event *tmp, *iter;
Expand Down Expand Up @@ -263,7 +262,8 @@ static int __ordered_events__flush(struct ordered_events *oe,
return 0;
}

int ordered_events__flush(struct ordered_events *oe, enum oe_flush how)
static int __ordered_events__flush(struct ordered_events *oe, enum oe_flush how,
u64 timestamp)
{
static const char * const str[] = {
"NONE",
Expand Down Expand Up @@ -302,6 +302,11 @@ int ordered_events__flush(struct ordered_events *oe, enum oe_flush how)
break;
}

case OE_FLUSH__TIME:
oe->next_flush = timestamp;
show_progress = false;
break;

case OE_FLUSH__ROUND:
case OE_FLUSH__NONE:
default:
Expand All @@ -312,7 +317,7 @@ int ordered_events__flush(struct ordered_events *oe, enum oe_flush how)
str[how], oe->nr_events);
pr_oe_time(oe->max_timestamp, "max_timestamp\n");

err = __ordered_events__flush(oe, show_progress);
err = do_flush(oe, show_progress);

if (!err) {
if (how == OE_FLUSH__ROUND)
Expand All @@ -328,6 +333,16 @@ int ordered_events__flush(struct ordered_events *oe, enum oe_flush how)
return err;
}

int ordered_events__flush(struct ordered_events *oe, enum oe_flush how)
{
return __ordered_events__flush(oe, how, 0);
}

int ordered_events__flush_time(struct ordered_events *oe, u64 timestamp)
{
return __ordered_events__flush(oe, OE_FLUSH__TIME, timestamp);
}

void ordered_events__init(struct ordered_events *oe, ordered_events__deliver_t deliver,
void *data)
{
Expand Down
2 changes: 2 additions & 0 deletions tools/perf/util/ordered-events.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ enum oe_flush {
OE_FLUSH__ROUND,
OE_FLUSH__HALF,
OE_FLUSH__TOP,
OE_FLUSH__TIME,
};

struct ordered_events;
Expand Down Expand Up @@ -55,6 +56,7 @@ int ordered_events__queue(struct ordered_events *oe, union perf_event *event,
u64 timestamp, u64 file_offset);
void ordered_events__delete(struct ordered_events *oe, struct ordered_event *event);
int ordered_events__flush(struct ordered_events *oe, enum oe_flush how);
int ordered_events__flush_time(struct ordered_events *oe, u64 timestamp);
void ordered_events__init(struct ordered_events *oe, ordered_events__deliver_t deliver,
void *data);
void ordered_events__free(struct ordered_events *oe);
Expand Down

0 comments on commit 68ca5d0

Please sign in to comment.