fix: emit nominal tag in declaration #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Nominal` type has not been working (possibly for a long time)
because the tag was not being emitted by the typescript compiler. This
didn't show up in testing because the tests are not run against the
emitted definitions.
Instead of emitting:
```typescript
class Tagged<N extends string> { private __tagged__: N }
```
we were getting
```typescript
class Tagged<N extends string> { __tagged__ }
```
thus nothing was tagged any longer.
Switching from `private` to `protected` fixes the emit issue while still
hiding the tag from the end user.
|
🎉 This PR is included in version 3.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Nominaltype has not been working (possibly for a long time)because the tag was not being emitted by the typescript compiler. This
didn't show up in testing because the tests are not run against the
emitted definitions.
Instead of emitting:
we were getting
thus nothing was tagged any longer.
Switching from
privatetoprotectedfixes the emit issue while stillhiding the tag from the end user.