Skip to content

feat: Add the ability to fetch remote licenses for pnpm-lock.yaml files#4286

Merged
kzantow merged 2 commits intoanchore:mainfrom
timols:feat/add-licenses-pnpm
Oct 16, 2025
Merged

feat: Add the ability to fetch remote licenses for pnpm-lock.yaml files#4286
kzantow merged 2 commits intoanchore:mainfrom
timols:feat/add-licenses-pnpm

Conversation

@timols
Copy link
Copy Markdown
Contributor

@timols timols commented Oct 15, 2025

Description

Extending #2708 to also be able to retrieve remote licenses from pnpm-lock.yaml.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have added unit tests that cover changed behavior
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

@kzantow
Copy link
Copy Markdown
Contributor

kzantow commented Oct 16, 2025

This looks great but I don't see that the remote license functionality is well tested. Would it make sense to add a test like the yarn cataloging? Maybe I've missed some tests, but it would be great to have a little more confidence there, to me.

P.S. it looks like static-analysis failures, you could try to use make lint-fix to fix them

@timols
Copy link
Copy Markdown
Contributor Author

timols commented Oct 16, 2025

Certainly - happy to do it. Will turn this around shortly.

Signed-off-by: Tim Olshansky <456103+timols@users.noreply.github.com>
@timols timols force-pushed the feat/add-licenses-pnpm branch from 7047ca6 to 5b59b83 Compare October 16, 2025 15:55
Signed-off-by: Tim Olshansky <456103+timols@users.noreply.github.com>
@timols timols force-pushed the feat/add-licenses-pnpm branch from 5b59b83 to 69f130f Compare October 16, 2025 15:55
@timols
Copy link
Copy Markdown
Contributor Author

timols commented Oct 16, 2025

@kzantow test added!

Copy link
Copy Markdown
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for the contribution @timols!

@kzantow kzantow merged commit c0f32e1 into anchore:main Oct 16, 2025
12 checks passed
@timols timols deleted the feat/add-licenses-pnpm branch October 16, 2025 18:14
@timols
Copy link
Copy Markdown
Contributor Author

timols commented Oct 17, 2025

@kzantow added this for Python too - #4295 😄

@willmurphyscode willmurphyscode added the enhancement New feature or request label Oct 22, 2025
spiffcs added a commit that referenced this pull request Oct 22, 2025
* main:
  chore(deps): update tools to latest versions (#4302)
  chore(deps): bump github.com/github/go-spdx/v2 from 2.3.3 to 2.3.4 (#4301)
  chore(deps): bump github/codeql-action from 4.30.8 to 4.30.9 (#4299)
  support universal (fat) mach-o binary files (#4278)
  chore(deps): bump sigstore/cosign-installer from 3.10.0 to 4.0.0 (#4296)
  chore(deps): bump anchore/sbom-action from 0.20.7 to 0.20.8 (#4297)
  convert posix path back to windows (#4285)
  Remove duplicate image source providers (#4289)
  chore(deps): bump anchore/sbom-action from 0.20.6 to 0.20.7 (#4293)
  feat: add option to fetch remote licenses for pnpm-lock.yaml files (#4286)
  Add PDM parser (#4234)
  chore(deps): update tools to latest versions (#4291)
  fix: panic during java archive maven resolution (#4290)
  Extract zip archive with multiple entries (#4283)
  chore: update to use old configuration on new cosign (#4287)
  chore(deps): update anchore dependencies (#4282)
  chore(deps): bump github.com/mholt/archives from 0.1.3 to 0.1.5 (#4280)
  add docs to configs (#4281)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants