Merge multiple targets for the same .NET package#3869
Merged
Conversation
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
wagoodman
force-pushed
the
dotnet-duplicate-targets
branch
from
379df8d to
23de228
Compare
Contributor
|
Ok, built this and ran it with the script in #3866, which previously failed (as in, created a non-duplicate SBOM) pretty quickly. It has run over 50 times now with no differences in the SBOMs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible for multiple targets in a deps.json to be for the same package, something that is not considered today (so the first target wins). In cases where we process the first target we might associate PE binaries with the deps.json package, however, if we process with other target first (which might have fewer PE references) then we will not associate that PE with the package and create a unique package.
This PR merges targets together so that dependencies and DLL paths are preserved, thus, multiple runs of syft should always produce the same results.
Type of change
Checklist