chore: reduce duplicate case SwiftPkg#2696
Merged
spiffcs merged 1 commit intoanchore:mainfrom Mar 7, 2024
testwill:dup_case
Merged
chore: reduce duplicate case SwiftPkg#2696spiffcs merged 1 commit intoanchore:mainfrom testwill:dup_case
spiffcs merged 1 commit intoanchore:mainfrom
testwill:dup_case
Conversation
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
spiffcs
requested changes
Mar 7, 2024
| case string(Dotnet), ".net", packageurl.TypeNuget: | ||
| return Dotnet | ||
| case packageurl.TypeCocoapods, packageurl.TypeSwift, string(CocoapodsPkg), string(SwiftPkg): | ||
| case packageurl.TypeCocoapods, packageurl.TypeSwift, string(CocoapodsPkg): |
Contributor
There was a problem hiding this comment.
Thanks for the slate of PRs @testwill - I'll take some time today to validate these today. I'm trying to figure out why this was duplicated in the first place:
// TypeCocoapods is a pkg:cocoapods purl.
--
66 | TypeCocoapods = "cocoapods"
CocoapodsPkg Type = "pod"]
Looks like these are two different strings here so it's not a duplicate case =)
Thanks for the due diligence on checking this though.
Closing for now given the different names.
If you think this could be clearer let me know and I can reopen and we can figure out what the chance should be
Contributor
There was a problem hiding this comment.
💯 - my fault I totally switched gears and looked at the wrong value change - this is good to go!
Line 42 in e2a9d89
Same string
spiffcs
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.