Normalize cataloger configuration patterns#2365
Merged
Conversation
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
kzantow
approved these changes
Nov 28, 2023
Contributor
kzantow
left a comment
kzantow
left a comment
There was a problem hiding this comment.
LGTM except the use of "central", unless I'm misunderstanding it
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
github-actions
Bot
removed
the
breaking-change
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* normalize cataloger patterns Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * remove central reference for maven configurable Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> --------- Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures the following is true amongst all catalogers:
pkg.Catalogerinterfaces over instances*CatalogerConfig)Default*CatalogerConfig)This also adds a common struct for any cataloger within
syft/cataloging, which will be more heavily used in #1383 .The breaking change made in this PR is renaming existing cataloger option structs within the
javaandgolangpackages.(This work was broken off of PR #1383)