Skip to content

Retrieve remote licenses using pom.properties when there is no pom.xml#2315

Merged
spiffcs merged 1 commit intoanchore:mainfrom
coheigea:coheigea/GetLicensesFromPomProperties
Dec 5, 2023
Merged

Retrieve remote licenses using pom.properties when there is no pom.xml#2315
spiffcs merged 1 commit intoanchore:mainfrom
coheigea:coheigea/GetLicensesFromPomProperties

Conversation

@coheigea
Copy link
Copy Markdown
Contributor

The Java remote licensing check only works if there is a pom.xml in the archive. This PR adds support to retrieve a remote pom from maven central using the information in pom.properties. With this it correctly finds a license for the snmp4j dependency which is a sub-component of https://repo1.maven.org/maven2/org/apache/servicemix/bundles/org.apache.servicemix.bundles.snmp4j/2.6.3_1/

@coheigea coheigea force-pushed the coheigea/GetLicensesFromPomProperties branch from d767db5 to f5fa9fb Compare November 13, 2023 16:19
@coheigea coheigea marked this pull request as draft November 13, 2023 16:25
@coheigea coheigea force-pushed the coheigea/GetLicensesFromPomProperties branch from f5fa9fb to e26f263 Compare November 14, 2023 06:06
@coheigea coheigea marked this pull request as ready for review November 14, 2023 06:25
@coheigea coheigea force-pushed the coheigea/GetLicensesFromPomProperties branch 2 times, most recently from b427859 to 5957859 Compare November 27, 2023 07:08
Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
@coheigea coheigea force-pushed the coheigea/GetLicensesFromPomProperties branch from 5957859 to d25bb4b Compare November 30, 2023 06:30
@coheigea
Copy link
Copy Markdown
Contributor Author

@spiffcs Reminder about a review for this please :-)

@spiffcs spiffcs merged commit 3ba9df4 into anchore:main Dec 5, 2023
spiffcs added a commit to coheigea/syft that referenced this pull request Dec 5, 2023
* main: (40 commits)
  chore(deps): bump anchore/sbom-action from 0.15.0 to 0.15.1 (anchore#2392)
  Retrieve remote licenses using pom.properties when there is no pom.xml (anchore#2315)
  fix(java): improve identification for org.apache.tapestry artifacts (anchore#2384)
  fix(java): improve identification for io.ratpack artifacts (anchore#2379)
  fix(java): improve identification for org.apache.cassandra artifacts (anchore#2386)
  fix(java): improve identification for org.neo4j.procedure artifacts (anchore#2388)
  fix: bump fangs for ptr summarize fix (anchore#2387)
  fix(java): improve identification for org.elasticsearch artifacts (anchore#2383)
  fix(java): improve identification for org.apache.geode artifacts (anchore#2382)
  fix(java): improve identification for org.apache.tomcat.embed artifacts (anchore#2381)
  fix(java): improve identification for io.projectreactor.netty artifacts (anchore#2378)
  fix(java): improve identification for org.eclipse.platform artifacts (anchore#2349)
  Generalize UI events for cataloging tasks (anchore#2369)
  chore(deps): update tools to latest versions (anchore#2376)
  chore(deps): bump github.com/google/go-containerregistry (anchore#2377)
  chore: fix tests failing due to Mac Rosetta cache (anchore#2374)
  fix: improve dotnet portable executable identification (anchore#2133)
  fix file metadata cataloger to use resolved locations (anchore#2370)
  fix: logging level for parsing potential PE files (anchore#2367)
  only remove breaking-change label when there are schema changes (anchore#2371)
  ...

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@coheigea coheigea deleted the coheigea/GetLicensesFromPomProperties branch December 5, 2023 16:34
@willmurphyscode willmurphyscode added the enhancement New feature or request label Dec 21, 2023
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
anchore#2315)

Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants