Check maven central as well for licenses in parents poms for nested jars#2302
Merged
Conversation
coheigea
force-pushed
the
coheigea/license-nested
branch
from
ad34245 to
a6213ec
Compare
Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
coheigea
force-pushed
the
coheigea/license-nested
branch
from
a6213ec to
30e29b3
Compare
spiffcs
approved these changes
Nov 8, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
…ars (anchore#2302) Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code currently only checks Maven Central for a license in a parent pom for the topmost package, and not for any embedded jars.
With this PR it detects a license correctly for xbean-spring which is embedded inside activemq-osgi: https://repo1.maven.org/maven2/org/apache/activemq/activemq-osgi/5.18.2/