feat: add bash classifier#2055
Merged
Merged
Conversation
Signed-off-by: witchcraze <witchcraze@gmail.com>
kzantow
reviewed
Aug 24, 2023
| // @(#)Bash version 5.2.0(1) alpha GNU | ||
| // @(#)Bash version 5.2.0(1) beta GNU | ||
| // @(#)Bash version 5.2.0(1) rc4 GNU | ||
| `(?m)@\(#\)Bash version (?P<version>[0-9]+\.[0-9]+\.[0-9]+)\([0-9]\) [a-z0-9]+ GNU`, |
Contributor
There was a problem hiding this comment.
Does this regex need the end bits [a-z0-9]+ GNU?
Contributor
There was a problem hiding this comment.
the nice thing about having the suffix you highlighted is that it's more specific, which means we have less chance of matching something that is not bash. The possible downside is if there are other builds of bash that might not have this suffix. My vote is to leave it as specific as possible until we find evidence that we're missing other builds that don't have this suffix.
kzantow
approved these changes
Aug 24, 2023
Contributor
kzantow
left a comment
kzantow
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution @witchcraze 👍
This was referenced Aug 28, 2023
Closed
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: witchcraze <witchcraze@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a binary cataloger for bash
Fixes #1963