fix: properly parse conan ref and include user and channel#2034
Conversation
Pro
force-pushed
the
fix-conan-ref-parse
branch
from
163e3d7 to
9f32dff
Compare
kzantow
left a comment
kzantow
left a comment
There was a problem hiding this comment.
This looks like a great start! Would you be able to add a test with some realistic samples of conanfile and lockfile entries?
Pro
force-pushed
the
fix-conan-ref-parse
branch
from
9f32dff to
5a4f877
Compare
Done, added some tests @kzantow |
Pro
force-pushed
the
fix-conan-ref-parse
branch
from
5a4f877 to
9d21265
Compare
|
@Pro -- you should be able to fix the static analysis failure by running |
Pro
force-pushed
the
fix-conan-ref-parse
branch
from
9d21265 to
97072c5
Compare
|
@Pro it looks like the last commit was not signed-off; could you rebase against main and force push these changes with sign-off? |
Signed-off-by: Stefan Profanter <stefan.profanter@agile-robots.com>
Pro
force-pushed
the
fix-conan-ref-parse
branch
from
97072c5 to
0b7ad64
Compare
|
Thanks for this PR @Pro -- there is one very small request to not export the Do you happen to know much about Conan lockfiles version 0.5? I've been trying to find information about the schema, but I've been unsuccessful. There is a report that the format may have changed significantly in an incompatible manner, and we'd like to make sure to support both older and newer versions. |
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
) * fix: properly parse conan ref and include user and channel Signed-off-by: Stefan Profanter <stefan.profanter@agile-robots.com> * unexport the conanRef type Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> --------- Signed-off-by: Stefan Profanter <stefan.profanter@agile-robots.com> Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> Co-authored-by: Alex Goodman <wagoodman@users.noreply.github.com>
3 participants
The current implementation in syft is not parsing the user and channel from a conan ref.
Both are highly relevant for the resulting package version.
https://github.com/CycloneDX/cyclonedx-conan is parsing the user and channel and putting it in the resulting file.
With this MR the same functionality is also added to syft.