Skip to content

chore: restore cataloger.DefaultConfig#2028

Merged
kzantow merged 3 commits into
mainfrom
chore/restore-default-config
Aug 14, 2023
Merged

chore: restore cataloger.DefaultConfig#2028
kzantow merged 3 commits into
mainfrom
chore/restore-default-config

Conversation

@kzantow
Copy link
Copy Markdown
Contributor

@kzantow kzantow commented Aug 14, 2023

The cataloger.DefaultConfig was removed due to only being used in tests within this repo, but as it is used downstream, this PR restores the function.

Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow added the changelog-ignore do not add a entry for this when generating the changelog label Aug 14, 2023
@kzantow kzantow enabled auto-merge (squash) August 14, 2023 19:58
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 14, 2023

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz%0A                                                              │ ./.tmp/benchmark-6acfb90.txt │%0A                                                              │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       15.73m ±  5%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        896.7µ ±  5%25%0AImagePackageCatalogers/binary-cataloger-2                                       257.9µ ±  2%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       814.3µ ±  5%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   26.93µ ±  4%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             112.5µ ±  1%25%0AImagePackageCatalogers/java-cataloger-2                                         16.97m ±  3%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         110.6µ ±  2%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           491.5µ ±  3%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    355.5µ ±  6%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       1.017m ±  2%25%0AImagePackageCatalogers/portage-cataloger-2                                      618.4µ ±  3%25%0AImagePackageCatalogers/python-package-cataloger-2                               4.166m ±  2%25%0AImagePackageCatalogers/r-package-cataloger-2                                    256.6µ ± 10%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       718.6µ ±  4%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 1.226m ±  3%25%0AImagePackageCatalogers/sbom-cataloger-2                                         148.6µ ±  4%25%0Ageomean                                                                         615.2µ%0A%0A                                                              │ ./.tmp/benchmark-6acfb90.txt │%0A                                                              │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       5.144Mi ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        205.6Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                       30.46Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       172.6Ki ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   3.696Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             9.906Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                         2.822Mi ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         8.594Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           94.19Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    49.32Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       186.8Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                      120.2Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                               1.003Mi ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                    53.30Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       181.3Ki ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 144.1Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                         14.20Ki ± 0%25%0Ageomean                                                                         100.5Ki%0A%0A                                                              │ ./.tmp/benchmark-6acfb90.txt │%0A                                                              │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                        88.14k ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                         4.190k ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                         848.0 ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                        3.145k ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                     132.0 ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                               281.0 ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                          40.63k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                           228.0 ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                            1.342k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                      898.0 ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                        4.079k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                       2.272k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                                16.44k ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                      929.0 ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                        3.992k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                  2.447k ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                           394.0 ± 0%25%0Ageomean                                                                          2.063k

Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow merged commit 5910732 into main Aug 14, 2023
@kzantow kzantow deleted the chore/restore-default-config branch August 14, 2023 20:28
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-ignore do not add a entry for this when generating the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants