Skip to content

Create nginx binary classifier#1988

Merged
kzantow merged 4 commits intoanchore:mainfrom
AikidoSec:add-support-for-nginx-binary-version-detection
Aug 3, 2023
Merged

Create nginx binary classifier#1988
kzantow merged 4 commits intoanchore:mainfrom
AikidoSec:add-support-for-nginx-binary-version-detection

Conversation

@SemProvoost
Copy link
Copy Markdown
Contributor

Create nginx binary classifier

Closes #1945

Signed-off-by: SemProvoost <27961543+SemProvoost@users.noreply.github.com>
Signed-off-by: SemProvoost <27961543+SemProvoost@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to add a couple tests for this? There are a few ways to do this: copy a small amount out of the binary that contains the version, you can see examples of this in the test fixtures here. Alternately, you can extract a binary from a (small, hopefully) image, see examples here.

Comment thread syft/pkg/cataloger/binary/default_classifiers.go Outdated
Signed-off-by: SemProvoost <27961543+SemProvoost@users.noreply.github.com>
Signed-off-by: SemProvoost <27961543+SemProvoost@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add binary cataloger for Nginx built from source

2 participants