Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: background reader apart from global handler for testing #1929

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Jul 12, 2023

Add individual WG to background reader to track/block on buffer being read for snapshot tests

This should fix the race condition in CI rather than bumping iterations n number of times like we had in the past

@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz%0A                                                          │ ./.tmp/benchmark-a7523a8.txt │%0A                                                          │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                   14.05m ±  3%25%0AImagePackageCatalogers/apkdb-cataloger-2                                    853.5µ ±  1%25%0AImagePackageCatalogers/binary-cataloger-2                                   236.1µ ±  3%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                   705.3µ ±  2%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                              1.447m ±  1%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                         109.1µ ±  1%25%0AImagePackageCatalogers/java-cataloger-2                                     16.14m ±  1%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                     105.6µ ±  2%25%0AImagePackageCatalogers/javascript-package-cataloger-2                       479.3µ ± 24%25%0AImagePackageCatalogers/nix-store-cataloger-2                                330.0µ ±  1%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                   952.8µ ±  1%25%0AImagePackageCatalogers/portage-cataloger-2                                  570.4µ ±  1%25%0AImagePackageCatalogers/python-package-cataloger-2                           4.003m ±  1%25%0AImagePackageCatalogers/r-package-cataloger-2                                241.2µ ±  1%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                   649.4µ ±  3%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                             1.110m ±  1%25%0AImagePackageCatalogers/sbom-cataloger-2                                     141.3µ ±  1%25%0Ageomean                                                                     728.1µ%0A%0A                                                          │ ./.tmp/benchmark-a7523a8.txt │%0A                                                          │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                   5.116Mi ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                    204.8Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                   30.24Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                   168.9Ki ± 0%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                              405.3Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                         9.906Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                     2.827Mi ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                     8.594Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                       100.9Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                49.14Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                   186.7Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                  119.9Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                           1.003Mi ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                53.30Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                   180.9Ki ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                             144.0Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                     14.20Ki ± 0%25%0Ageomean                                                                     132.7Ki%0A%0A                                                          │ ./.tmp/benchmark-a7523a8.txt │%0A                                                          │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                    87.74k ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                     4.182k ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                     830.0 ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                    3.002k ± 0%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                               6.338k ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                           281.0 ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                      39.88k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                       228.0 ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                        1.404k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                  895.0 ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                    4.079k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                   2.268k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                            16.44k ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                  929.0 ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                    3.989k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                              2.447k ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                       394.0 ± 0%25%0Ageomean                                                                      2.583k

Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for digging on this 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants