Fix version detection in Java archive name parsing #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Luhring <[email protected]>
This was referenced Jun 29, 2023
Closed
Closed
Closed
Open
This was referenced Jul 12, 2023
Open
Closed
Closed
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
…1889) Signed-off-by: Dan Luhring <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug, caused by someone who shall remain nameless, where parsing the package name and version from a Java archive filename treated any strings that began with "build" as versions.
This leads to a large number of false positives in Grype because it feeds invalid versions into Grype's version comparison logic.
I believe the original intent was to ensure build numbers were treated as version components, which is valid, but when the package name included "build" with no number directly following (such as in
gradle-build-cache-8.1.1), the "build" was automatically starting the version data, not continuing the package name data.This has been addressed by changing
*to+in a regex. 😆