-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return both failures when failed to retrive an image with a scheme #1801
Conversation
e83805c
to
e64e4a2
Compare
Signed-off-by: Idan Frimark <[email protected]>
e64e4a2
to
3e4b84e
Compare
Hi @FrimIdan, thank you for the pull request! We've been looking at similar issues recently, and we might want to move some of this processing into stereoscope itself. We will keep this ticket updated as we investigate. Thanks again. |
I believe this issue is also related: #1695 |
@tgerla ok. I hope it can be sorted quickly, the current situation is confusing and my pr might be a temp solution until a better will be integrated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anchore/tools This is approved - waiting on a 2nd before merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a step in the right direction as it at least raises up enough information for the user to see. In a future iteration there may be opportunity to make it a little less verbose.
* main: (21 commits) chore(deps): bump github.com/sirupsen/logrus from 1.9.2 to 1.9.3 (#1862) chore(deps): bump modernc.org/sqlite from 1.22.1 to 1.23.0 (#1863) feat: source-version flag (#1859) chore(deps): bump github.com/spf13/viper from 1.15.0 to 1.16.0 (#1851) accept main.version ldflags even without vcs (#1855) feat: add scope to pom properties (#1779) chore(deps): bump github.com/stretchr/testify from 1.8.3 to 1.8.4 (#1852) chore(deps): bump github.com/docker/docker (#1849) Add test to ensure package metadata is represented in the JSON schema (#1841) Fix directory resolver to consider CWD and root path input correctly (#1840) Migrate location-related structs to the file package (#1751) chore(deps): bump github.com/go-git/go-git/v5 from 5.6.1 to 5.7.0 (#1843) fix: add panic recovery for license parse (#1839) chore: return both failures when failed to retrieve an image with a scheme (#1801) Extract go module versions from ldflags for binaries built by go (#1832) fix: duplicate packages, support pnpm lockfile v6 (#1778) chore(deps): update stereoscope to e14bc4437b2eac481c5b6f101890b22df4f33596 (#1834) chore(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3 (#1829) chore(deps): bump github.com/docker/docker (#1833) Keep original FileInfo persisted on file.Metadata structs (#1794) ... Signed-off-by: Christopher Phillips <[email protected]>
…cheme (anchore#1801) Signed-off-by: Idan Frimark <[email protected]>
This PR is meant to solve an issue we've got when syft failed to print the "right" error upon fetch failure.
For example, i'm trying to scan an arm64 image with an amd64 syft CLI and i'm getting the following error:
The error is not clear,
unable to determine image source
is wrong since i've provideddocker
scheme.When running the same command with debug I can see the correct failure.
So in this PR I've returned both errors so it will be more clear:
Solves #1569