Skip to content

Reduce log spam on unknown relationship type #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willmurphyscode merged 5 commits into from
May 10, 2023
Merged

Reduce log spam on unknown relationship type #1797

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d1af16
Lower log level in unknown relationship type
willmurphyscode May 8, 2023
506c15c
Use debug instead of trace
willmurphyscode May 8, 2023
205aa08
Warn only once for all unknwon relationship types
willmurphyscode May 9, 2023
cad77e0
add unit tests for warn only once
willmurphyscode May 9, 2023
deeabd5
Deduplicate conversion errors generically
willmurphyscode May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion syft/formats/syftjson/to_syft_model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func toSyftRelationship(idMap map[string]interface{}, relationship model.Relatio
case artifact.OwnershipByFileOverlapRelationship, artifact.ContainsRelationship, artifact.DependencyOfRelationship, artifact.EvidentByRelationship:
default:
if !strings.Contains(string(typ), "dependency-of") {
log.Warnf("unknown relationship type: %s", typ)
log.Debugf("unknown relationship type: %s", typ)
return nil
}
// lets try to stay as compatible as possible with similar relationship types without dropping the relationship
Expand Down