Skip to content

Rename pkg.Catalog to pkg.Collection#1764

Merged
wagoodman merged 1 commit intomainfrom
rename-pkg-catalog
Apr 26, 2023
Merged

Rename pkg.Catalog to pkg.Collection#1764
wagoodman merged 1 commit intomainfrom
rename-pkg-catalog

Conversation

@wagoodman
Copy link
Copy Markdown
Contributor

@wagoodman wagoodman commented Apr 26, 2023

As part of the work under #558 (from #558 (comment)) renames the pkg.Catalog to pkg.Collection. The existing pkg.Catalog type and constructor is still in the codebase as a type alias and deprecation notice. The type aliases will be removed in syft 1.0.

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman force-pushed the rename-pkg-catalog branch from 78a3333 to cdcd8a2 Compare April 26, 2023 17:26
@wagoodman wagoodman requested a review from a team April 26, 2023 17:27
@wagoodman wagoodman self-assigned this Apr 26, 2023
@wagoodman wagoodman added the deprecated A functionality is being deprecated label Apr 26, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2023

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz%0A                                                          │ ./.tmp/benchmark-e09e94b.txt │%0A                                                          │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                   11.65m ±  1%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                             855.4µ ±  1%25%0AImagePackageCatalogers/python-package-cataloger-2                           3.121m ±  0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                   736.8µ ±  2%25%0AImagePackageCatalogers/javascript-package-cataloger-2                       372.4µ ±  1%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                   557.0µ ±  2%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                   473.2µ ±  2%25%0AImagePackageCatalogers/java-cataloger-2                                     13.24m ±  1%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                     92.43µ ±  0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                    564.3µ ±  1%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                         93.78µ ± 10%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                              1.219m ±  2%25%0AImagePackageCatalogers/portage-cataloger-2                                  337.4µ ±  0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                253.3µ ±  1%25%0AImagePackageCatalogers/sbom-cataloger-2                                     117.9µ ±  0%25%0AImagePackageCatalogers/binary-cataloger-2                                   216.4µ ±  0%25%0AImagePackageCatalogers/linux-kernel-cataloger-2                             34.69m ±  8%25%0Ageomean                                                                     776.0µ%0A%0A                                                          │ ./.tmp/benchmark-e09e94b.txt │%0A                                                          │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                   5.068Mi ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                             140.3Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                           984.9Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                   179.4Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                       98.87Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                   169.8Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                   178.8Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                     2.784Mi ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                     8.750Ki ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                    145.2Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                         10.06Ki ± 0%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                              409.2Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                  85.93Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                48.90Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                     14.21Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                   31.99Ki ± 0%25%0AImagePackageCatalogers/linux-kernel-cataloger-2                             62.65Mi ± 0%25%0Ageomean                                                                     192.9Ki%0A%0A                                                          │ ./.tmp/benchmark-e09e94b.txt │%0A                                                          │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                    86.83k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                              2.280k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                            15.95k ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                    3.796k ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                        1.322k ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                    2.989k ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                    3.878k ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                      39.47k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                       228.0 ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                     3.666k ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                           281.0 ± 0%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                               6.325k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                   1.660k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                  884.0 ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                       394.0 ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                     896.0 ± 0%25%0AImagePackageCatalogers/linux-kernel-cataloger-2                              2.798k ± 0%25%0Ageomean                                                                      2.649k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecated A functionality is being deprecated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants