feat: Add config option to allow user to select the default image source location#1703
Merged
Conversation
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Contributor
Author
|
cc @luhring |
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Contributor
|
@spiffcs This looks amazing! Thank you so so much!!! I just tried it out and it works great so far. 🤩 Two cents:
|
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Contributor
Author
|
I'll get this cleaned up now with the readme section and behavior change - thanks for the quick feedback! |
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
wagoodman
reviewed
Mar 30, 2023
wagoodman
reviewed
Mar 30, 2023
wagoodman
reviewed
Mar 30, 2023
wagoodman
reviewed
Mar 30, 2023
wagoodman
reviewed
Mar 30, 2023
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
wagoodman
reviewed
Mar 30, 2023
wagoodman
reviewed
Mar 30, 2023
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
wagoodman
approved these changes
Mar 31, 2023
Contributor
|
You all rock!!! |
This was referenced Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add config option to allow user to select the default image source location
Syft is consumed by upstream tools for generating SBOM. These SBOM can be generated from a variety of sources including local and OCI registry images.
anchore/grype#1204 surfaces the need for allowing a user to express a preference over the default source to be used when building an SBOM for an image (and then subsequently generating a vulnerability scan).
This first step adds a config option into syft and changes the library behavior so this preference can be injected into the SBOM generation process. A follow up PR will be made for grype to adapt to this new ability.
Demo showing latest updates:
Registry value pulls source from OCI registry
Docker value pulls source from

local Docker DaemonNo value keeps the same current behavior of default order lookup