fix: handle individual cataloger panics#1636
Merged
kzantow merged 2 commits intoanchore:mainfrom Mar 1, 2023
Merged
Conversation
Signed-off-by: Keith Zantow <kzantow@gmail.com>
kzantow
commented
Mar 1, 2023
wagoodman
approved these changes
Mar 1, 2023
Contributor
wagoodman
left a comment
wagoodman
left a comment
There was a problem hiding this comment.
consider my earlier comment a nit -- overall this should prevent a lot of issues we see from time to time as we start scaling the amount of catalogers we have in the codebase
Signed-off-by: Keith Zantow <kzantow@gmail.com>
This was referenced Mar 2, 2023
Closed
Merged
Closed
Closed
Open
Bump github.com/anchore/syft from 0.34.0 to 0.74.0
nvtkaszpir/chart-testing#86
Open
This was referenced Mar 10, 2023
Open
Closed
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles any panics that occur within individual catalogers, allowing cataloging to continue and an SBOM to be generated.
Fixes #1624