feat: rust toolchain binary cataloger#1601
Merged
westonsteimel merged 1 commit intomainfrom Mar 1, 2023
Merged
Conversation
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
westonsteimel
force-pushed
the
rust-toolchain-cataloger
branch
from
c2e4e78 to
a440961
Compare
kzantow
previously approved these changes
Feb 22, 2023
Contributor
kzantow
left a comment
kzantow
left a comment
There was a problem hiding this comment.
It might be nice to cut down the size of some of the test fixtures (some are in the MB range)
wagoodman
requested changes
Feb 22, 2023
Contributor
wagoodman
left a comment
wagoodman
left a comment
There was a problem hiding this comment.
...some are in the MB range....
it seems like there may be an extra addition to the gitignore needed for the busybox image fixture tar
westonsteimel
force-pushed
the
rust-toolchain-cataloger
branch
from
a440961 to
93ae287
Compare
Contributor
Author
I think it might already be excluded - I had to force add my test cases since they'd normally be excluded and must have accidentally picked up that as well |
westonsteimel
force-pushed
the
rust-toolchain-cataloger
branch
2 times, most recently
from
731abd9 to
3090714
Compare
kzantow
approved these changes
Feb 24, 2023
Contributor
kzantow
left a comment
kzantow
left a comment
There was a problem hiding this comment.
The /rust-1.67.1/toolchains/stable-x86_64-unknown-linux-musl/lib/libstd-86aefecbddda356d.so is still 1.25 MB, it would be nice to just copy the small (maybe < 100 bytes) binary bits that are required for matching. Other than that, 👍
Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
westonsteimel
force-pushed
the
rust-toolchain-cataloger
branch
from
3090714 to
5e70c7d
Compare
Contributor
|
@wagoodman I think all new fixture changes are now only in the <30kb size now: Did you have other changes requested for this PR? Otherwise LGTM |
wagoodman
reviewed
Mar 1, 2023
| }, | ||
| { | ||
| Class: "rust-standard-library-linux", | ||
| FileGlob: "**/libstd-????????????????.so", |
Contributor
There was a problem hiding this comment.
good call, that is more specific and not too crazy for the index parsing in stereoscope 🙌
wagoodman
approved these changes
Mar 1, 2023
This was referenced Mar 2, 2023
Closed
Merged
Closed
Closed
This was referenced Mar 6, 2023
Bump github.com/anchore/syft from 0.34.0 to 0.74.0
nvtkaszpir/chart-testing#86
Open
Open
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds binary classifier for the rust toolchain for linux and mac