Skip to content

haproxy binary matcher#1591

Merged
kzantow merged 5 commits intoanchore:mainfrom
noqcks:benji/haproxy-binary-classifier
Feb 23, 2023
Merged

haproxy binary matcher#1591
kzantow merged 5 commits intoanchore:mainfrom
noqcks:benji/haproxy-binary-classifier

Conversation

@noqcks
Copy link
Copy Markdown
Contributor

@noqcks noqcks commented Feb 18, 2023

Matching here was a little more difficult as some versions of HAProxy have semvers after text like this HA-Proxy version 1.5.14 while some have it before like this 2.7.3-1065b10HAProxy version

I couldn't find a way match HAProxy either before OR after the version match group in one regex, so I split into two.

Images used in test-fixtures

haproxy:1.8.22-alpine
haproxy:1.5.14
haproxy:2.7.3

Closes #1512

Signed-off-by: Benji Visser <benji@093b.org>
@noqcks
Copy link
Copy Markdown
Contributor Author

noqcks commented Feb 18, 2023

Not sure why these tests are failing, my branch is up to date w/ main

Comment thread syft/pkg/cataloger/binary/default_classifiers.go
Signed-off-by: Benji Visser <benji@093b.org>
@noqcks noqcks requested a review from kzantow February 23, 2023 19:31
Copy link
Copy Markdown
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@kzantow kzantow merged commit abfec62 into anchore:main Feb 23, 2023
@noqcks noqcks deleted the benji/haproxy-binary-classifier branch February 23, 2023 20:11
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Benji Visser <benji@093b.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Catalog haproxy binary

2 participants