fix: do not leak attestation password or key path to console or SBOM contents #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Phillips <[email protected]>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
Signed-off-by: Christopher Phillips <[email protected]>
wagoodman
reviewed
Feb 3, 2023
Signed-off-by: Christopher Phillips <[email protected]>
wagoodman
approved these changes
Feb 3, 2023
wagoodman
changed the title
This was referenced Feb 6, 2023
Closed
Closed
Closed
Bump github.com/anchore/syft from 0.34.0 to 0.70.0
nvtkaszpir/chart-testing#79
Closed
Closed
Closed
This was referenced Feb 13, 2023
Merged
Closed
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* fix: update config struct to not decode password/key * test: update tests to confirm no secrets in output Signed-off-by: Christopher Phillips <[email protected]> --------- Signed-off-by: Christopher Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
keyandpasswordconfig fields when runningsyft attestto not be displayed in the console or encoded into SBOMs.In the previous state plain text of the fields would be output during a syft run where the
configis printed to the console. This is NOT the desired behavior. Instead, this change updates the tag values so that the fields are ignored and not decoded onto theyamlorjsonoutputs displayed by syft.Note - the code can still use these values, but they are no longer exposed as a part of any logging or encoded into SBOMs.
Affects syft versions >= v0.69.0 && <0.70.0
Related Links:
Signed-off-by: Christopher Phillips [email protected]