Skip to content

Add purls for binary classifiers#1435

Merged
kzantow merged 1 commit intoanchore:mainfrom
noqcks:benji.visser/add-purls-for-binary-matches
Jan 4, 2023
Merged

Add purls for binary classifiers#1435
kzantow merged 1 commit intoanchore:mainfrom
noqcks:benji.visser/add-purls-for-binary-matches

Conversation

@noqcks
Copy link
Copy Markdown
Contributor

@noqcks noqcks commented Jan 3, 2023

I noticed that purls were empty for binary matched packages

  {
      "id": "42128c6f2809fa6c",
      "name": "go",
      "version": "1.19.4",
      "type": "binary",
      "foundBy": "binary-cataloger",
      ...
      "purl": "",
      ...
  },

And after

  {
     "id": "42128c6f2809fa6c",
     "name": "go",
     "version": "1.19.4",
     "type": "binary",
     "foundBy": "binary-cataloger",
     ...
     "purl": "pkg:generic/go@1.19.4",
     ...
  },

Reference: purl-spec generic type

cc: @kzantow

Signed-off-by: Benji Visser <benji@093b.org>
Copy link
Copy Markdown
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@kzantow kzantow merged commit bc1edb9 into anchore:main Jan 4, 2023
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Benji Visser <benji@093b.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants