Skip to content

Add spdx relationship encoding for dependencies#1342

Merged
spiffcs merged 2 commits intomainfrom
fix-spdx-decode-relationships
Nov 18, 2022
Merged

Add spdx relationship encoding for dependencies#1342
spiffcs merged 2 commits intomainfrom
fix-spdx-decode-relationships

Conversation

@wagoodman
Copy link
Copy Markdown
Contributor

This is a follow up to #1063 to prevent warning outputs for unsupported relationship types:

Screen Shot 2022-11-15 at 11 29 56 AM

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman added the bug Something isn't working label Nov 15, 2022
@wagoodman wagoodman requested a review from a team November 15, 2022 16:30
@wagoodman wagoodman self-assigned this Nov 15, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 15, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    15.3ms ± 6%    11.7ms ± 1%  -23.71%  (p=0.008 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.79ms ±13%    1.35ms ±10%  -24.25%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            4.27ms ± 1%    3.31ms ± 0%  -22.54%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.39ms ± 6%    1.08ms ± 0%  -21.85%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         978µs ± 3%     752µs ± 0%  -23.04%  (p=0.008 n=5+5)
ImagePackageCatalogers/node-binary-cataloger-2               8.02µs ± 3%    6.81µs ± 1%  -15.11%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.11ms ± 5%    0.87ms ± 2%  -21.33%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                    1.66ms ± 5%    1.28ms ± 1%  -22.89%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      18.5ms ± 3%    14.5ms ± 0%  -21.95%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.73ms ± 4%    1.33ms ± 1%  -22.63%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          8.16µs ± 5%    6.87µs ± 1%  -15.81%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.80ms ± 2%    1.37ms ± 0%  -24.05%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    935µs ± 2%     717µs ± 0%  -23.32%  (p=0.008 n=5+5)
ImagePackageCatalogers/sbom-cataloger-2                      5.52ms ± 4%    4.45ms ± 1%  -19.35%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.26MB ± 0%    5.26MB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               205kB ± 0%     205kB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             961kB ± 0%     961kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     217kB ± 0%     217kB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         159kB ± 0%     159kB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/node-binary-cataloger-2               1.12kB ± 0%    1.12kB ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     199kB ± 0%     199kB ± 0%     ~     (p=0.310 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                     302kB ± 0%     303kB ± 0%   +0.12%  (p=0.016 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.49MB ± 0%    3.48MB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.26MB ± 0%    1.26MB ± 0%   -0.04%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          1.12kB ± 0%    1.12kB ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                375kB ± 0%     374kB ± 0%   -0.10%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    138kB ± 0%     139kB ± 0%   +0.17%  (p=0.008 n=5+5)
ImagePackageCatalogers/sbom-cataloger-2                       722kB ± 0%     722kB ± 0%   -0.01%  (p=0.008 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%     ~     (p=0.881 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.24k ± 0%     4.24k ± 0%     ~     (p=0.444 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             16.5k ± 0%     16.5k ± 0%     ~     (p=0.476 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.50k ± 0%     5.50k ± 0%     ~     (p=0.730 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         3.33k ± 0%     3.33k ± 0%     ~     (all equal)
ImagePackageCatalogers/node-binary-cataloger-2                 38.0 ± 0%      38.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.46k ± 0%     4.46k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpm-db-cataloger-2                     8.11k ± 0%     8.11k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%     ~     (p=0.794 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.45k ± 0%     5.45k ± 0%     ~     (p=0.484 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            38.0 ± 0%      38.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.12k ± 0%     7.12k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.58k ± 0%     3.58k ± 0%     ~     (p=0.079 n=5+5)
ImagePackageCatalogers/sbom-cataloger-2                       24.4k ± 0%     24.4k ± 0%     ~     (all equal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants