Generic Binary Cataloger#1336
Merged
kzantow merged 16 commits intoanchore:mainfrom Nov 29, 2022
Merged
Conversation
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Contributor
Author
|
cc: @jedevc |
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
reviewed
Nov 29, 2022
Contributor
wagoodman
left a comment
wagoodman
left a comment
There was a problem hiding this comment.
we should probably unexport some of the resources within the binary package such as DefaultClassifiers and Classifier since the only thing we intend for users to leverage is the cataloger itself
wagoodman
reviewed
Nov 29, 2022
wagoodman
reviewed
Nov 29, 2022
wagoodman
reviewed
Nov 29, 2022
Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
reviewed
Nov 29, 2022
wagoodman
reviewed
Nov 29, 2022
wagoodman
approved these changes
Nov 29, 2022
Signed-off-by: Keith Zantow <kzantow@gmail.com>
This was referenced Nov 30, 2022
Closed
Closed
This was referenced Dec 13, 2022
Closed
Closed
spiffcs
added a commit
to raboof/syft
that referenced
this pull request
Dec 20, 2022
* main: (87 commits) feat: Add license parsing for java (anchore#1385) fix: cyclonedx component type for binaries (anchore#1406) fix: openjdk detection pattern (anchore#1415) bug: spdx checksum empty array; allow syft to generate SHA1 for spdx-tag-value documents (anchore#1404) Add NetBSD support. (anchore#1412) feat: add catalog delete (anchore#1377) docs: remove file classifier (anchore#1397) chore: update latest cyclonedx library (anchore#1390) feat: Add Java binary catalogers (anchore#1392) chore: Update SPDX license list to 3.19 (anchore#1389) fix: add manual vendor/product removal to fix false flags (anchore#1070) Update Stereoscope to c5ff155d72f166e2332e160a75c3ff2b8e9c7e2e (anchore#1395) chore: fix test busybox image sha (anchore#1393) fix: go version not properly identified in binary (anchore#1384) Update Stereoscope to 3b80d983223f6e6fc2d33b0ffa003d30268418e9 (anchore#1376) fix: Update node binary package name (anchore#1375) feat: Generic Binary Cataloger (anchore#1336) recover from bad parsing of golang binary (anchore#1371) Fix parsing of apk databases with large entries (anchore#1365) Update syft bootstrap tools to latest versions. (anchore#1369) ...
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the file classifiers to a binary file cataloger, which surfaces packages based on binary files. This currently requires knowledge about a curated set of binaries including how to determine version information, which may mean scanning strings within the binary. This currently supports:
TODO:
add new schema