Skip to content

Port rust cataloger to new generic cataloger pattern#1323

Merged
wagoodman merged 1 commit intomainfrom
update-rust-generic-cataloger
Nov 4, 2022
Merged

Port rust cataloger to new generic cataloger pattern#1323
wagoodman merged 1 commit intomainfrom
update-rust-generic-cataloger

Conversation

@wagoodman
Copy link
Copy Markdown
Contributor

Follow up to #1281 , porting the rust cataloger to the new generic.Cataloger.

@wagoodman wagoodman requested a review from a team November 4, 2022 15:31
@wagoodman wagoodman enabled auto-merge (squash) November 4, 2022 15:31
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman force-pushed the update-rust-generic-cataloger branch from ea0bab2 to 68927a4 Compare November 4, 2022 15:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 4, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       time/op
ImagePackageCatalogers/alpmdb-cataloger-2                  13.9ms ± 1%
ImagePackageCatalogers/ruby-gemspec-cataloger-2            1.59ms ± 4%
ImagePackageCatalogers/python-package-cataloger-2          3.97ms ± 2%
ImagePackageCatalogers/php-composer-installed-cataloger-2  1.30ms ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2       905µs ± 1%
ImagePackageCatalogers/node-binary-cataloger-2             7.97µs ± 2%
ImagePackageCatalogers/dpkgdb-cataloger-2                  1.04ms ± 1%
ImagePackageCatalogers/rpm-db-cataloger-2                  1.52ms ± 1%
ImagePackageCatalogers/java-cataloger-2                    17.4ms ± 2%
ImagePackageCatalogers/apkdb-cataloger-2                   1.56ms ± 4%
ImagePackageCatalogers/go-module-binary-cataloger-2        7.98µs ± 1%
ImagePackageCatalogers/dotnet-deps-cataloger-2             1.65ms ± 2%
ImagePackageCatalogers/portage-cataloger-2                  865µs ± 1%

name                                                       alloc/op
ImagePackageCatalogers/alpmdb-cataloger-2                  5.27MB ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2             205kB ± 0%
ImagePackageCatalogers/python-package-cataloger-2           962kB ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2   218kB ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2       159kB ± 0%
ImagePackageCatalogers/node-binary-cataloger-2             1.12kB ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                   200kB ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                   303kB ± 0%
ImagePackageCatalogers/java-cataloger-2                    3.45MB ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                   1.25MB ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2        1.12kB ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2              376kB ± 0%
ImagePackageCatalogers/portage-cataloger-2                  139kB ± 0%

name                                                       allocs/op
ImagePackageCatalogers/alpmdb-cataloger-2                   85.7k ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2             4.26k ± 0%
ImagePackageCatalogers/python-package-cataloger-2           16.6k ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2   5.53k ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2       3.33k ± 0%
ImagePackageCatalogers/node-binary-cataloger-2               38.0 ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                   4.51k ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                   8.13k ± 0%
ImagePackageCatalogers/java-cataloger-2                     57.5k ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                    5.39k ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2          38.0 ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2              7.24k ± 0%
ImagePackageCatalogers/portage-cataloger-2                  3.59k ± 0%

@wagoodman wagoodman merged commit f319713 into main Nov 4, 2022
@wagoodman wagoodman deleted the update-rust-generic-cataloger branch November 4, 2022 16:07
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants