Skip to content

Port python cataloger to new generic cataloger pattern#1319

Merged
wagoodman merged 1 commit intomainfrom
update-python-generic-cataloger
Nov 4, 2022
Merged

Port python cataloger to new generic cataloger pattern#1319
wagoodman merged 1 commit intomainfrom
update-python-generic-cataloger

Conversation

@wagoodman
Copy link
Copy Markdown
Contributor

@wagoodman wagoodman commented Nov 3, 2022

Follow up to #1281 , porting the python cataloger to the new generic.Cataloger.

@wagoodman wagoodman requested a review from a team November 3, 2022 16:23
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 3, 2022 •
edited
Loading

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    15.0ms ± 1%    12.9ms ± 3%  -14.03%  (p=0.016 n=4+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.72ms ± 3%    1.42ms ± 5%  -17.18%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            4.27ms ± 4%    3.52ms ± 2%  -17.53%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.38ms ± 3%    1.13ms ± 2%  -18.00%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         985µs ± 2%     785µs ± 1%  -20.27%  (p=0.008 n=5+5)
ImagePackageCatalogers/node-binary-cataloger-2               8.06µs ± 3%    6.95µs ± 1%  -13.81%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.13ms ± 1%    0.93ms ± 1%  -18.25%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                    1.63ms ± 0%    1.35ms ± 1%  -17.31%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      17.9ms ± 1%    15.6ms ± 1%  -12.70%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.68ms ± 2%    1.47ms ± 4%  -12.28%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          8.01µs ± 4%    6.88µs ± 1%  -14.11%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.77ms ± 2%    1.49ms ± 1%  -16.13%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    924µs ± 2%     748µs ± 1%  -19.05%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.27MB ± 0%    5.27MB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               204kB ± 0%     204kB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             959kB ± 0%     962kB ± 0%   +0.34%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     218kB ± 0%     218kB ± 0%   +0.16%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         159kB ± 0%     159kB ± 0%   +0.07%  (p=0.032 n=5+5)
ImagePackageCatalogers/node-binary-cataloger-2               1.12kB ± 0%    1.12kB ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     200kB ± 0%     200kB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                     301kB ± 0%     302kB ± 0%   +0.17%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.45MB ± 0%    3.45MB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%     ~     (p=0.310 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          1.12kB ± 0%    1.12kB ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                376kB ± 0%     376kB ± 0%   -0.14%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    138kB ± 0%     139kB ± 0%   +0.11%  (p=0.008 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%     ~     (p=0.968 n=5+4)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.24k ± 0%     4.24k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             16.5k ± 0%     16.6k ± 0%   +0.22%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.53k ± 0%     5.53k ± 0%     ~     (p=0.968 n=5+4)
ImagePackageCatalogers/javascript-package-cataloger-2         3.33k ± 0%     3.33k ± 0%     ~     (p=0.444 n=5+5)
ImagePackageCatalogers/node-binary-cataloger-2                 38.0 ± 0%      38.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.51k ± 0%     4.51k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpm-db-cataloger-2                     8.11k ± 0%     8.11k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.6k ± 0%     57.5k ± 0%     ~     (p=0.063 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.39k ± 0%     5.39k ± 0%     ~     (p=1.000 n=4+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            38.0 ± 0%      38.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.24k ± 0%     7.24k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.58k ± 0%     3.58k ± 0%     ~     (all equal)

kzantow
kzantow approved these changes Nov 3, 2022
View reviewed changes
Comment thread syft/pkg/cataloger/python/package.go
return p
}

func newPackageForPackage(m pkg.PythonPackageMetadata, sources ...source.Location) pkg.Package {
Copy link
Copy Markdown
Contributor

@kzantow kzantow Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun name :)

Copy link
Copy Markdown
Contributor Author

@wagoodman wagoodman Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I couldn't think of another 👎

@wagoodman
port python cataloger to new generic cataloger pattern
a18b656 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman force-pushed the update-python-generic-cataloger branch from 4cac2fc to a18b656 Compare November 3, 2022 19:26
@wagoodman wagoodman merged commit 1076281 into main Nov 4, 2022
@wagoodman wagoodman deleted the update-python-generic-cataloger branch November 4, 2022 12:59
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
port python cataloger to new generic cataloger pattern (anchore#1319)
117658a 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzantow kzantow kzantow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wagoodman @kzantow