Skip to content

Update haskell cataloger to use updated generic cataloger#1290

Merged
wagoodman merged 1 commit intomainfrom
update-haskell-generic-cataloger
Oct 27, 2022
Merged

Update haskell cataloger to use updated generic cataloger#1290
wagoodman merged 1 commit intomainfrom
update-haskell-generic-cataloger

Conversation

@wagoodman
Copy link
Copy Markdown
Contributor

Follow up to #1281 , porting the hackage (haskell) cataloger to the new generic.Cataloger.

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman requested a review from a team October 25, 2022 17:45
@wagoodman wagoodman enabled auto-merge (squash) October 25, 2022 17:46
@github-actions
Copy link
Copy Markdown

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    14.2ms ± 5%    15.0ms ± 4%  +5.43%  (p=0.032 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.64ms ± 3%    1.73ms ±10%    ~     (p=0.056 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            4.32ms ±22%    4.06ms ± 6%    ~     (p=0.841 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.37ms ± 6%    1.29ms ± 3%  -5.46%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         935µs ± 4%     975µs ± 2%  +4.25%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.11ms ± 2%    1.09ms ± 3%    ~     (p=0.548 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                    1.57ms ± 2%    1.57ms ± 4%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      17.7ms ± 4%    18.2ms ± 5%    ~     (p=0.310 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.59ms ± 3%    1.56ms ± 6%    ~     (p=0.548 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          8.47µs ± 2%    8.29µs ± 5%    ~     (p=0.841 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.83ms ± 1%    1.72ms ± 5%  -5.94%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    911µs ± 3%     890µs ± 5%    ~     (p=0.222 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.26MB ± 0%    5.26MB ± 0%    ~     (p=0.421 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               202kB ± 0%     202kB ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             945kB ± 0%     945kB ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     214kB ± 0%     213kB ± 0%    ~     (p=0.310 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         158kB ± 0%     158kB ± 0%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     199kB ± 0%     199kB ± 0%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                     301kB ± 0%     301kB ± 0%    ~     (p=0.254 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.44MB ± 0%    3.44MB ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%    ~     (p=0.310 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          1.12kB ± 0%    1.12kB ± 0%    ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                376kB ± 0%     376kB ± 0%    ~     (p=0.310 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    136kB ± 0%     136kB ± 0%    ~     (p=1.000 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%    ~     (p=0.095 n=5+4)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.24k ± 0%     4.24k ± 0%    ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             16.5k ± 0%     16.5k ± 0%    ~     (p=0.603 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.50k ± 0%     5.50k ± 0%  -0.02%  (p=0.016 n=4+5)
ImagePackageCatalogers/javascript-package-cataloger-2         3.31k ± 0%     3.31k ± 0%    ~     (p=0.238 n=4+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.50k ± 0%     4.50k ± 0%    ~     (all equal)
ImagePackageCatalogers/rpm-db-cataloger-2                     8.11k ± 0%     8.11k ± 0%    ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%    ~     (p=0.952 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.39k ± 0%     5.39k ± 0%    ~     (all equal)
ImagePackageCatalogers/go-module-binary-cataloger-2            38.0 ± 0%      38.0 ± 0%    ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.32k ± 0%     7.32k ± 0%    ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.58k ± 0%     3.58k ± 0%    ~     (p=0.556 n=4+5)

@wagoodman wagoodman merged commit e52aa3b into main Oct 27, 2022
@wagoodman wagoodman deleted the update-haskell-generic-cataloger branch October 27, 2022 15:30
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants