Skip to content

Port conan cataloger to new generic cataloger pattern#1284

Merged
wagoodman merged 1 commit intomainfrom
update-conan-generic-cataloger
Oct 24, 2022
Merged

Port conan cataloger to new generic cataloger pattern#1284
wagoodman merged 1 commit intomainfrom
update-conan-generic-cataloger

Conversation

@wagoodman
Copy link
Copy Markdown
Contributor

Follow up to #1281 , porting the Conan cataloger to the new generic.Cataloger

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman requested a review from a team October 24, 2022 19:47
@github-actions
Copy link
Copy Markdown

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    11.7ms ± 1%    13.7ms ± 4%  +17.09%  (p=0.008 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.35ms ± 8%    1.59ms ± 7%  +17.73%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.32ms ± 1%    3.99ms ± 1%  +20.31%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.07ms ± 0%    1.28ms ± 2%  +19.56%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         751µs ± 1%     899µs ± 2%  +19.74%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     894µs ± 1%    1022µs ± 3%  +14.34%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                    1.29ms ± 0%    1.48ms ± 1%  +14.51%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      15.0ms ± 1%    17.5ms ± 3%  +16.76%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.27ms ± 0%    1.41ms ± 3%  +11.24%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.28µs ± 3%    2.55µs ± 1%  +11.96%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.38ms ± 1%    1.56ms ± 2%  +13.16%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    705µs ± 0%     815µs ± 1%  +15.55%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.26MB ± 0%    5.26MB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               202kB ± 0%     202kB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             944kB ± 0%     945kB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     213kB ± 0%     213kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         158kB ± 0%     158kB ± 0%     ~     (p=0.310 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     203kB ± 0%     203kB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                     302kB ± 0%     301kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.44MB ± 0%    3.44MB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                367kB ± 0%     368kB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    136kB ± 0%     136kB ± 0%     ~     (p=1.000 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.24k ± 0%     4.24k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             16.5k ± 0%     16.5k ± 0%     ~     (p=0.889 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.50k ± 0%     5.50k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         3.31k ± 0%     3.31k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.57k ± 0%     4.57k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpm-db-cataloger-2                     8.11k ± 0%     8.11k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%     ~     (p=0.794 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.39k ± 0%     5.39k ± 0%     ~     (p=0.095 n=4+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.15k ± 0%     7.15k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.58k ± 0%     3.58k ± 0%     ~     (p=0.095 n=5+4)

@wagoodman wagoodman enabled auto-merge (squash) October 24, 2022 19:56
@wagoodman wagoodman merged commit eb8ebd9 into main Oct 24, 2022
@wagoodman wagoodman deleted the update-conan-generic-cataloger branch October 24, 2022 20:11
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants