add template output by jonasagx · Pull Request #1051 · anchore/syft

jonasagx · 2022-06-16T01:56:55Z

Allow syft to output an SBOM based on a given Go template like Grype currently does. I added a new output format called template that receives as param the template file path. I extended the sbom.Format to accept format options that formats can use if they implement it the interface themselves.

Closes: #152

Signed-off-by: Jonas Xavier jonasx@anchore.com

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

wagoodman · 2022-06-17T14:19:31Z

 	Encode(io.Writer, SBOM) error
 	Decode(io.Reader) (*SBOM, error)
 	Validate(io.Reader) error
+	WithOptions(options.Format) Format


we shouldn't be changing this interface reactively

I see, I dropped it in favor of type casting to template format.

wagoodman · 2022-06-17T14:21:04Z

 			errs = multierror.Append(errs, fmt.Errorf("bad output format: '%s'", name))
 			continue
 		}
+		format = format.WithOptions(options.Format{TemplateFilePath: templateFilePath})


another way to achieve this without changing the Format interface is to type assert to template.Format, and if the assertion is ok, then add on the additional information or create a new instance of the format with the new information injected via a constructor.

yes, I like that idea. I used it and that helped drop options.Format.

wagoodman · 2022-06-17T14:23:10Z

+package options
+
+// Format has options to be used by SBOM formats
+type Format struct {


I see why this is here, however, it is a little awkward (it's only purpose is for the state of template and isn't clear how to use this for more formats in the future). Is there a better way to do this?

Right, I removed it. Now the template output receives the param directly.

wagoodman

I left a couple of comments around the format-options and downstream effects. The ultimate problem with the code (on main) is that there isn't a path to inject dependencies, which is the thing this PR is contending with.

I think there is a compromise that can be made without needing to change the Format interface, which is a pattern that affects all formats. That compromise can be made around https://github.com/anchore/syft/pull/1051/files#r900169470 . In the future we can pay down the improvement of injecting all formats from the application config (which solves this whole problem a lot better, but is out of scope for this PR).

luhring · 2022-06-17T13:46:40Z

 - `spdx-json`: A JSON report conforming to the [SPDX 2.2 JSON Schema](https://github.com/spdx/spdx-spec/blob/v2.2/schemas/spdx-schema.json).
 - `github`: A JSON report conforming to GitHub's dependency snapshot format.
 - `table`: A columnar summary (default).
+- `template`: Lets the user specify the output format. See "Using templates" below.


We should make this section name be a hyperlink to the section

I added the link 👍🏼

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

wagoodman · 2022-06-17T16:01:15Z

+}
+
+func (f OutputFormat) WithTemplate(filePath string) sbom.Format {
+	return OutputFormat{templateFilePath: filePath}


it's a little odd that this is worded like a functional option, but creates a new object like a builder pattern.

I think this fits a little better as a setter for a field on the instance it was called on, something like

f.SetTemplatePath(path)

(side steps the need to create a new instance of the format). The main reason why I'm mentioning this is that it would be easier to read and follow (setters are easier, the naming wouldn't conflict with other patterns, etc).

I see now. I've changed the func signature to that.

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

luhring · 2022-06-17T17:29:59Z

+		tmpl, ok := format.(template.OutputFormat)
+		if ok {


nit: This is often done on the same line in Go

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

luhring

Looks good!

* main: (70 commits) fix: add php catalogers to all catalogers (anchore#1065) feat: add use-all-catalogers flag (anchore#1050) Updates parsing of `yarn.lock` to use `resolved` URLs that are pulled from yarn and npm registries (anchore#926) remove OSS Meetup message (anchore#1057) add pom.xml cataloger (anchore#1055) Add support for CBL-Mariner distroless images (anchore#1045) Add catalogers configuration (anchore#1038) add template output (anchore#1051) update stereoscope to latest version (anchore#1052) update zip_read_closer to incorporate zip64 support (anchore#1041) Add pacman (alpm) parser support (anchore#943) Update of README.md (anchore#1027) bump cosign to v1.9.0 to resolve reporting of GHSA-66x3-6cw3-v5gj (anchore#1025) add workflows to test new project automation (anchore#1023) improve LanguageByName and add unit tests (anchore#1034) Read Description from dpkg status files (anchore#996) Add announcement for Anchore OSS Virtual Meetup (anchore#1033) add main module field to go bin metadata (anchore#1026) Add filters to package cataloger (anchore#1021) change draft to false for release process (anchore#1016) ... Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>

* add template output Signed-off-by: Jonas Xavier <jonasx@anchore.com> * remove dead code Signed-off-by: Jonas Xavier <jonasx@anchore.com> * fix template cli flag Signed-off-by: Jonas Xavier <jonasx@anchore.com> * implement template's own format type Signed-off-by: Jonas Xavier <jonasx@anchore.com> * simpler code Signed-off-by: Jonas Xavier <jonasx@anchore.com> * fix readme link to Go template Signed-off-by: Jonas Xavier <jonasx@anchore.com> * feedback changes Signed-off-by: Jonas Xavier <jonasx@anchore.com> * simpler func signature patter Signed-off-by: Jonas Xavier <jonasx@anchore.com> * nit Signed-off-by: Jonas Xavier <jonasx@anchore.com> * fix linter error Signed-off-by: Jonas Xavier <jonasx@anchore.com>

jonasagx added 6 commits June 15, 2022 18:56

add template output

b7a1395

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

remove dead code

787de6b

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

fix template cli flag

b76e736

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

implement template's own format type

0eff022

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

simpler code

04a2cd3

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

fix readme link to Go template

68eb426

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

jonasagx marked this pull request as ready for review June 16, 2022 19:48

wagoodman reviewed Jun 17, 2022

View reviewed changes

luhring reviewed Jun 17, 2022

View reviewed changes

feedback changes

915c792

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

wagoodman reviewed Jun 17, 2022

View reviewed changes

simpler func signature patter

f46432f

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

luhring reviewed Jun 17, 2022

View reviewed changes

jonasagx added 2 commits June 17, 2022 10:36

nit

be56791

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

fix linter error

4184436

Signed-off-by: Jonas Xavier <jonasx@anchore.com>

luhring approved these changes Jun 17, 2022

View reviewed changes

luhring merged commit aed1599 into anchore:main Jun 17, 2022

jonasagx deleted the add-template-output branch June 17, 2022 19:51

Conversation

jonasagx commented Jun 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonasagx Jun 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wagoodman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wagoodman Jun 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luhring left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jonasagx commented Jun 16, 2022 •

edited

Loading

jonasagx Jun 17, 2022 •

edited

Loading

wagoodman Jun 17, 2022 •

edited

Loading