Skip to content

convert posix path back to windows #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoeyShapiro wants to merge 1 commit into from
Closed

convert posix path back to windows #464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion pkg/file/metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import (
"os"
"path"
"path/filepath"
"runtime"
"strings"
"time"

"github.com/sylabs/squashfs"
Expand Down Expand Up @@ -128,7 +130,13 @@ func NewMetadataFromPath(path string, info os.FileInfo) Metadata {
ty := TypeFromMode(info.Mode())

if ty == TypeRegular {
f, err := os.Open(path)
usablePath := path
// denormalize the path back to windows so we can open the file
if runtime.GOOS == "windows" {
usablePath = FromPosix(usablePath)
}

f, err := os.Open(usablePath)
if err != nil {
// TODO: it may be that the file is inaccessible, however, this is not an error or a warning. In the future we need to track these as known-unknowns
f = nil
Expand Down Expand Up @@ -167,3 +175,15 @@ func (m Metadata) Equal(other Metadata) bool {
m.FileInfo.Size() == other.FileInfo.Size() &&
m.FileInfo.ModTime().UTC().Equal(other.FileInfo.ModTime().UTC())
}

func FromPosix(posixPath string) (windowsPath string) {
// decode the volume (e.g. /c/<path> --> C:\\) - There should always be a volume name.
pathFields := strings.Split(posixPath, "/")
volumeName := strings.ToUpper(pathFields[1]) + `:\\`

// translate non-escaped forward slashes into backslashes
remainingTranslatedPath := strings.Join(pathFields[2:], "\\")

// combine volume name and backslash components
return filepath.Clean(volumeName + remainingTranslatedPath)
}
Loading