Auto-detect Singularity images#142
Merged
Merged
Conversation
Re-factor helper functions used to set up in-memory filesystems used in unit tests. Signed-off-by: Adam Hughes <9903835+tri-adam@users.noreply.github.com>
Modify detectSourceFromPath to auto-detect Singularity container images. Extend unit tests to cover new functionality. Signed-off-by: Adam Hughes <9903835+tri-adam@users.noreply.github.com>
tri-adam
force-pushed
the
detect-singularity
branch
from
fe4a299 to
6e36d1e
Compare
This was referenced Sep 1, 2022
kzantow
reviewed
Sep 19, 2022
Signed-off-by: Adam Hughes <9903835+tri-adam@users.noreply.github.com>
tri-adam
force-pushed
the
detect-singularity
branch
from
a234c69 to
c0ca043
Compare
kzantow
reviewed
Sep 19, 2022
Contributor
kzantow
left a comment
kzantow
left a comment
There was a problem hiding this comment.
Just a couple more comments here -- hopefully which make sense! I'm thinking about maintenance and having a pattern of returning callbacks makes things a bit harder to debug from my experience.
Return afero.Fs directly from dummy functions, as per code review feedback. Signed-off-by: Adam Hughes <9903835+tri-adam@users.noreply.github.com>
kzantow
approved these changes
Sep 20, 2022
Contributor
kzantow
left a comment
kzantow
left a comment
There was a problem hiding this comment.
LGTM -- just one more minor comment
Contributor
|
Thanks for the contribution, @tri-adam! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify
detectSourceFromPathto auto-detect Singularity container images. Re-factorpkg/imageunit tests to accommodate more thorough SIF test cases, and extend unit tests to cover new functionality.I believe this may address anchore/syft#1189.