Parse java group ID and artifact ID from PURL when missing#2675
Merged
Parse java group ID and artifact ID from PURL when missing#2675
Conversation
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
kzantow
approved these changes
May 20, 2025
270f58b to
f74003c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow on to anchore/syft#3922 where there will no longer be a
syftPkg.JavaArchive.PomPropertiesto reliably read java group ID / artifact ID from on SBOM decode operations. Specifically, this can't be depended on in cases where we don't know if the data actually came from apom.propertiesfile. Instead this is done when creating a grype package when we detect the package represents a java package.PR stack
pkg.JavaArchive.PomPropertiesis being populated even though nopom.propertiesfile was present for analysis syft#3922 CI will fail until this is merged and incorporated here