Conversation
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
wagoodman
force-pushed
the
return-cmd
branch
from
97796e3 to
e57f711
Compare
kzantow
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a breaking change to the EventHandler such that it can also return a
tea.Cmd. Today the models that are returned from the handlers are meant to act like factories, returning only newly created models, which processing downstream will callInit()on the models to get anytea.Cmds. However, if you are looking to respond to an event on the bus that will not create a new model to be managed by downstream processing but instead a new model that will be subsumed into an existing model, there isn't a way to communicate the subsumed model'sInit()commands.This PR changes this behavior by allowing for event handlers to optionally also return a
tea.Cmdfor new models that are not returned by the handler to.