feat: excluding removed 'files' at 'synchronize' (#44)

* feat: excluding removed and renamed 'files' * fix(chat): unnecessary comma
anc95 · Mar 19, 2023 · 7ee7c69 · 7ee7c69
1 parent a472ee1
commit 7ee7c69
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 17 deletions.
diff --git a/src/bot.ts b/src/bot.ts
@@ -1,4 +1,5 @@
 import { Context, Probot } from 'probot';
+
 import { Chat } from './chat.js';
 
 const OPENAI_API_KEY = 'OPENAI_API_KEY';
@@ -67,22 +68,20 @@ export const robot = (app: Probot) => {
 
       let { files: changedFiles, commits } = data.data;
 
-      if (context.payload.action === 'synchronize') {
-        if (commits.length >= 2) {
-          const {
-            data: { files },
-          } = await context.octokit.repos.compareCommits({
-            owner: repo.owner,
-            repo: repo.repo,
-            base: commits[commits.length - 2].sha,
-            head: commits[commits.length - 1].sha,
-          });
-
-          const filesNames = files?.map((file) => file.filename) || [];
-          changedFiles = changedFiles?.filter((file) =>
-            filesNames.includes(file.filename)
-          );
-        }
+      if (context.payload.action === 'synchronize' && commits.length >= 2) {
+        const {
+          data: { files },
+        } = await context.octokit.repos.compareCommits({
+          owner: repo.owner,
+          repo: repo.repo,
+          base: commits[commits.length - 2].sha,
+          head: commits[commits.length - 1].sha,
+        });
+
+        const filesNames = files?.map((file) => file.filename) || [];
+        changedFiles = changedFiles?.filter((file) =>
+          filesNames.includes(file.filename)
+        );
       }
 
       if (!changedFiles?.length) {
@@ -95,6 +94,10 @@ export const robot = (app: Probot) => {
         const file = changedFiles[i];
         const patch = file.patch || '';
 
+        if(file.status !== 'modified' && file.status !== 'added') {
+          continue;
+        }
+
         if (!patch || patch.length > MAX_PATCH_COUNT) {
           continue;
         }

diff --git a/src/chat.ts b/src/chat.ts
@@ -15,7 +15,7 @@ export class Chat {
 
   private generatePrompt = (patch: string) => {
     const answerLanguage = process.env.LANGUAGE
-      ? `,Answer me in ${process.env.LANGUAGE},`
+      ? `Answer me in ${process.env.LANGUAGE},`
       : '';
 
     return `Bellow is the code patch, please help me do a brief code review,${answerLanguage} if any bug risk and improvement suggestion are welcome