Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nova 4 #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ronvanderheijden
Copy link

  • added abstract menu function

@ronvanderheijden
Copy link
Author

ronvanderheijden commented Sep 1, 2022

Closes: #36

@dmyers
Copy link

dmyers commented Feb 21, 2023

@anaseqal Do you think you can take a look at this contribution?

@anditsung
Copy link
Contributor

@anaseqal Do you think you can take a look at this contribution?

Nova4 use vue3. Cannot just add a menu to make it work on nova4

@ronvanderheijden
Copy link
Author

@anditsung The code is broken, this fix has nothing to do with vue3 or any other front-end parts.

@anditsung
Copy link
Contributor

code is definitely broken but only fix the compatibility on nova4
without updating the frontend still cant be use on nova4

@ronvanderheijden
Copy link
Author

I've tested it and it's working properly. You aren't even using this menu feature, so I don't get your comment.
Anyway, You can close this pull-request. I'll be using the fork, which does the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants