docs: clarify example.jsonl vs materialized_inputs, apply style guide - #1
Open
lbliii wants to merge 1 commit into
Open
Conversation
Address review feedback on PR #1560: 'materialized Responses format' read as the generated *_materialized_inputs.jsonl files. Reword to 'Responses API format' and explicitly note example.jsonl is distinct from the rollout-collection materialized_inputs artifacts. Apply NVIDIA doc style guide to the changed lines: expand contractions (won't -> will not), spell out a small number, and use 'refer to' instead of 'see'. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Lawrence Lane <llane@nvidia.com>
github-actions
Bot
added
the
sla:triage-overdue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to address review feedback on NVIDIA-NeMo#1560 (merges into that PR's branch).
Changes
example.jsonlis not the same as the generated*_materialized_inputs.jsonlfiles. The word "materialized" was the source of confusion. Reworded "materialized Responses format" → "Responses API format" and added an explicit note thatexample.jsonlis distinct from the rollout-collection*_materialized_inputs.jsonlartifacts.won't→will not), spell out a single-digit count (5→five), and userefer toinstead ofsee.Files:
.claude/skills/add-benchmark/SKILL.md,fern/versions/latest/pages/data/prepare-validate.mdx🤖 Generated with Claude Code