Rework the linting support to support disabling eslint errors. #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also gain support for adding the @ts-ignore flag that the tsc compiler understands.
|
Sorry about the late response. If it's OK, I'll hold on investigating this PR, until the questions I've raised in #308 are put down or resolved 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also gain support for adding the @ts-ignore flag that the tsc compiler understands.
This change adds logic for identifying the general type of checker from which flycheck errors are reported, and so be able to add the right flag when the user requests that an error be turned off.
This tackles point 2 of this post.
I've been running this for a while in projects that use eslint for all linting work, and projects that still use tslint, and it's been working for me.