Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check viewport-unit-variants #173

Conversation

ZhukDmitryOlegovich
Copy link

Hello,

I'm new to doing PR in open source, so if I'm doing something wrong, I'll be glad to receive feedback

I decided to add doiuse to my project and there are a couple of things that stop me from using it, so I’m going to make a series of PRs in which I propose corrections or improvements that will help me


  1. Added a test case that doesn’t work for me
    .test {
      /* include `5vb` */
      background-image: url("data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTYiIGhlaWdodD0iMTYiIGZpbGw9Im5vbmUiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+PHBhdGggZmlsbC1ydWxlPSJldmVub2RkIiBjbGlwLXJ1bGU9ImV2ZW5vZGQiIGQ9Ik02LjU4NiA4TDQuMjkzIDUuNzA3YS45OTkuOTk5IDAgMTExLjQxNC0xLjQxNEw4IDYuNTg1bDIuMjkzLTIuMjkyYTEgMSAwIDAxMS40MTQgMS40MTNMOS40MTQgOGwyLjI5MyAyLjI5NGExIDEgMCAwMS0xLjQxNCAxLjQxNEw4IDkuNDEzbC0yLjI5MyAyLjI5M2ExIDEgMCAwMS0xLjQxNC0xLjQxNUw2LjU4NiA4eiIgZmlsbD0iIzI3MkIzNyIgZmlsbC1vcGFjaXR5PSIuMiIvPjwvc3ZnPg==")
                                                                                       /* `5vb` here ^^^ */
    }
  2. Corrected the viewport-unit-variants check function by fix checkCSSLengthUnits

@clshortfuse clshortfuse added this to the 6.0.3 milestone Sep 25, 2023
@clshortfuse clshortfuse merged commit e52a4a4 into anandthakker:master Oct 4, 2023
2 of 3 checks passed
@clshortfuse
Copy link
Collaborator

All looks good. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants