Upgrade to NAN v2 to support iojs 3.0 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivan Thanks for the PR! Will merge after the release of io.js 3.0. |
|
The |
|
You beat me to it! I was just updating the PR after checking out @rvagg's tweet. :) Now awaiting the Travis-ci suite to successfully complete to merge. |
anandsuresh
added a commit
that referenced
this pull request
Aug 1, 2015
Upgrade to NAN v2 to support iojs 3.0
|
wow, great work @ivan, not an easy task to get up to speed with the changes in nan@2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io.js 3.0 will come with V8 4.4, which has changed so many C++ APIs that it requires NAN v2. Here I have just run a NAN 1->2 converter from nodejs/nan#376 (comment) and confirmed that the resulting sse4_crc32 works with io.js/next (3.0) and io.js 2.4.0.
No point in merging until io.js 3.0 is released, I am just providing this for reference now.
package.jsonwill need to have the nan version fixed later.